Rover: null check for unconfigured RCMAP_YAW #11820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was briefly talked about at the last devcall so I'll tag it again so we can talk about a better all-vehicle all-channel solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix vehicles configured with RCMAP_YAW = 0 which causes an insta-crash on boot due to unused channels being assigned as nullptr. Yaw (lateral) is optional for several vehicle types, however steering and throttle is universal so if those aren't configured you'll have other major problems.
Likely a different fix should be done globally for all channels and all vehicles.
This is a good candidate to backport to a Rover release.